Move quote tagging to Staging #8342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#8302
branch
from
dc429ad to
4fd5f04
Compare
nicolasstucki
changed the title
liufengyun
approved these changes
Feb 19, 2020
| @@ -52,7 +52,8 @@ object PickledQuotes { | |||
| private def dealiasTypeTags(tp: Type)(implicit ctx: Context): Type = new TypeMap() { | |||
| override def apply(tp: Type): Type = { | |||
| val tp1 = tp match { | |||
| case tp: TypeRef if tp.typeSymbol.hasAnnotation(defn.InternalQuoted_QuoteTypeTagAnnot) => tp.dealias | |||
| case tp: TypeRef if tp.typeSymbol.hasAnnotation(defn.InternalQuoted_QuoteTypeTagAnnot) => | |||
| tp.symbol.info.hiBound | |||
There was a problem hiding this comment.
For some reason the type aliases get transformed into type bounds with equivalent upper and lower bound but they do not get dealiased. I will investigate further.
nicolasstucki
force-pushed
the
fix-#8302
branch
4 times, most recently
from
f306d32 to
c24a4d3
Compare
Fix scala#8302, fix scala#8052 and fix scala#7521
nicolasstucki
force-pushed
the
fix-#8302
branch
from
c24a4d3 to
e1b2378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8302, fix #8052 and fix #7521.